-
Notifications
You must be signed in to change notification settings - Fork 12
Transition to uv
#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR refactors the project to transition from Poetry to uv for dependency management, project installation, and test execution. Key changes include:
- Updating pyproject.toml to use the new [project] configuration and uv settings with Hatchling.
- Modifying GitHub workflows to install uv, set up Python, and run tests and commands using uv.
- Revising documentation and README links and commands to reflect the switch from Poetry to uv.
Reviewed Changes
| File | Description |
|---|---|
| pyproject.toml | Refactors configuration from Poetry to uv and Hatchling |
| .github/workflows/cat-test-examples.yml | Updates steps to install uv and run tests using uv |
| .github/workflows/python-tests.yml | Similar update to install uv and run tests commands |
| examples/team_recommender/readme.md | Updates local setup instructions to use uv |
| docs/getting-started.md | Adds instructions to use uv for project setup |
| README.md | Switches test and code quality commands to uv and updates documentation links |
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.github/workflows/cat-test-examples.yml:35
- The test command now targets a specific subdirectory which differs from the previous broader directory. Please verify that the new path is correct and intentional for running the example tests.
run: uv run pytest examples/team_recommender/tests/example_4_gate_on_success_threshold/
README.md:37
- The archive link has been updated from pointing to 'wiki/ARCHIVE.md' to 'wiki'. Please confirm that this change correctly reflects the new location of the archive content.
- [Archive - To see potentially helpful previous iterations of the code](wiki)
6e23129 to
f0f4f43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR transitions the project’s workflows and configuration from Poetry to uv, updating the setup, installation, and test commands accordingly. Key changes include:
- Refactoring the pyproject.toml to use the [project] section with dependency groups instead of Poetry’s configuration.
- Updating GitHub workflows to install and run the project using uv instead of Poetry.
- Modifying documentation and example files to reflect the new uv-based setup.
Reviewed Changes
| File | Description |
|---|---|
| pyproject.toml | Refactored project configuration and dependency groups. |
| .github/workflows/cat-test-examples.yml | Replaced Poetry steps with uv installation and command usage. |
| .github/workflows/python-tests.yml | Updated test workflow to use uv for linting and testing commands. |
| docs/getting-started.md | Added uv installation instructions alongside existing setup info. |
| examples/team_recommender/readme.md | Updated local setup instructions to use uv commands instead of Poetry. |
| README.md | Revised test and code quality commands and updated documentation links. |
| examples/team_recommender/conftest.py | Removed an unused import to clean up the file. |
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
paulz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
- Replaced setup from local action to `astral-sh/setup-uv@v5` and `actions/setup-python@v5`. - Updated Python setup to use `python-version-file: "pyproject.toml"`. - Changed project installation command to `uv sync --all-extras --dev`. - Modified test commands to use `uv run` instead of `poetry run`. - Updated documentation link in README Signed-off-by: Tim Kersey <[email protected]>
f0f4f43 to
6275650
Compare
Refactor GitHub workflows to use
uvfor setup and project installationastral-sh/setup-uv@v5andactions/setup-python@v5.python-version-file: "pyproject.toml".uv sync --all-extras --dev.uv runinstead ofpoetry run.